From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 Date: Mon, 05 Mar 2012 16:13:24 +0200 Message-ID: <4F54CA04.4070804@redhat.com> References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> <4F54C1C0.6030803@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Peter Maydell , =?UTF-8?B?QW5kcmVhcyBGw6RyYg==?= =?UTF-8?B?ZXI=?= , Anthony Liguori , quintela@redhat.com, Developers qemu-devel , KVM devel mailing list , Dmitry Solodkiy To: i.mitsyanko@samsung.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:23366 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932469Ab2CEONg (ORCPT ); Mon, 5 Mar 2012 09:13:36 -0500 In-Reply-To: <4F54C1C0.6030803@samsung.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/05/2012 03:38 PM, Igor Mitsyanko wrote: >> Short summary: >> * switch wp groups to bitfield rather than int array >> * convert sd.c to use memory_region_init_ram() to allocate the wp >> groups >> (being careful to use memory_region_set_dirty() when we touch them) >> * we don't need variable-length fields for sd.c any more >> * rest of the vmstate conversion is straightforward >> > > OK, it turned out to be not so simple, we can't use memory API in sd.c > because TARGET_PHYS_ADDR_BITS value (and, consequently, > target_phys_addr_t) is not defined for common objects. > Well, can't you make sd.c target dependent? It's not so nice, but it does solve the problem. -- error compiling committee.c: too many arguments to function