From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait Date: Tue, 06 Mar 2012 10:01:43 +0100 Message-ID: <4F55D277.9000708@redhat.com> References: <1330936455-23802-1-git-send-email-pbonzini@redhat.com> <4F548263.1070905@siemens.com> <4F54CC8A.5010509@redhat.com> <4F54CDFE.3030309@redhat.com> <4F54D866.30402@redhat.com> <4F54E64C.4050506@redhat.com> <4F54F97D.4080504@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , qemu-devel@nongnu.org, kvm@vger.kernel.org, laurent@vivier.eu, anthony@codemonkey.ws To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:12845 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964952Ab2CFJBz (ORCPT ); Tue, 6 Mar 2012 04:01:55 -0500 In-Reply-To: <4F54F97D.4080504@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 05/03/2012 18:35, Avi Kivity ha scritto: >>> > > The I/O handlers would still use the qemu mutex, no? we'd just protect >>> > > the select() (taking the mutex from before releasing the global lock, >>> > > and reacquiring it afterwards). >> > >> > Yes, that could work, but it is _really_ ugly. > Yes, it is... > Let's just fix it in NBD then. Paolo