From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Enable VMX-related bits in MSR_IA32_FEATURE_CONTROL. Date: Wed, 07 Mar 2012 12:07:35 +0200 Message-ID: <4F573367.5000707@redhat.com> References: <1331046141-11101-1-git-send-email-js@alien8.de> <4F5629A0.8060209@redhat.com> <20120306154738.GA15125@fermat.math.technion.ac.il> <20120306173308.GA20590@fermat.math.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Julian Stecklina , kvm@vger.kernel.org To: "Nadav Har'El" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31837 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751399Ab2CGKHz (ORCPT ); Wed, 7 Mar 2012 05:07:55 -0500 In-Reply-To: <20120306173308.GA20590@fermat.math.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 03/06/2012 07:33 PM, Nadav Har'El wrote: > On Tue, Mar 06, 2012, Nadav Har'El wrote about "Re: [PATCH] KVM: Enable VMX-related bits in MSR_IA32_FEATURE_CONTROL.": > > 2. handle_vmon() does not check the previous setting of this MSR. > > If the guest (or its BIOS) doesn't set both FEATURE_CONTROL_LOCKED > > and FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX, it should get a > > By the way, am I right in my understanding that KVM doesn't support > SMX in the guest? Isn't nested vmx crazy enough? btw, any updates on nested EPT? Nested vmx is pointless without it. > I didn't see mention of CR4.SMXE or a GETSEC exit > handler, which is why I'm assuming that it doesn't... > If this assumption isn't true, I'll also need to worry about the > ..._INSIDE_SMX case. -- error compiling committee.c: too many arguments to function