* can't restore a guest saved by an older qemu
@ 2012-03-02 6:33 Ren, Yongjie
2012-03-02 8:47 ` Jan Kiszka
0 siblings, 1 reply; 6+ messages in thread
From: Ren, Yongjie @ 2012-03-02 6:33 UTC (permalink / raw)
To: Avi Kivity; +Cc: KVM list
Hi Avi,
I can't restore a guest saved by an older qemu. I wonder if this issue is introduced by some latest commits on the file 'hw/i8254.c'.
The new commit: b5ed4b6f (on Mar 1) I tried to restore a guest using this qemu.
The old commit: 9d636ae7 (on Feb 11) I saved a guest using this qemu.
I got some error when restoring a guest saved by an old qemu now.
[root@vt-nhm9 jay]# qemu-system-x86_64 -smp 4 -m 1024 -hda rhel6u1.qcow -incoming "exec:dd if=save.img"
Could not open option rom 'vapic.bin': No such file or directory
qemu-system-x86_64: pci_add_option_rom: failed to find romfile "pxe-rtl8139.rom"
VNC server running on `::1:5900'
Unknown ramblock "0000:00:03.0/rtl8139.rom", cannot accept migration
qemu: warning: error while loading state for instance 0x0 of device 'ram'
load of migration failed
dd: writing to `standard output': Broken pipe
193+0 records in
192+0 records out
98304 bytes (98 kB) copied, 0.00713571 s, 13.8 MB/s
A good one is something like the following.
[root@vt-nhm9 jay]# ~/qemu-kvm/x86_64-softmmu/qemu-system-x86_64 -smp 4 -m 1024 -hda rhel6u1.qcow -incoming "exec:dd if=save1.img"
VNC server running on `::1:5900'
781430+1 records in
781430+1 records out
400092473 bytes (400 MB) copied, 1.03926 s, 385 MB/s
Best Regards,
Yongjie Ren (Jay)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: can't restore a guest saved by an older qemu 2012-03-02 6:33 can't restore a guest saved by an older qemu Ren, Yongjie @ 2012-03-02 8:47 ` Jan Kiszka 2012-03-02 8:58 ` Zhang, Yang Z 0 siblings, 1 reply; 6+ messages in thread From: Jan Kiszka @ 2012-03-02 8:47 UTC (permalink / raw) To: Ren, Yongjie; +Cc: Avi Kivity, KVM list On 2012-03-02 07:33, Ren, Yongjie wrote: > Hi Avi, > I can't restore a guest saved by an older qemu. I wonder if this issue is introduced by some latest commits on the file 'hw/i8254.c'. > The new commit: b5ed4b6f (on Mar 1) I tried to restore a guest using this qemu. > The old commit: 9d636ae7 (on Feb 11) I saved a guest using this qemu. > > I got some error when restoring a guest saved by an old qemu now. > [root@vt-nhm9 jay]# qemu-system-x86_64 -smp 4 -m 1024 -hda rhel6u1.qcow -incoming "exec:dd if=save.img" > Could not open option rom 'vapic.bin': No such file or directory > qemu-system-x86_64: pci_add_option_rom: failed to find romfile "pxe-rtl8139.rom" > VNC server running on `::1:5900' > Unknown ramblock "0000:00:03.0/rtl8139.rom", cannot accept migration > qemu: warning: error while loading state for instance 0x0 of device 'ram' > load of migration failed Confirmed. I get a different error, but something is broken here as well. Bisecting... Thanks, Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: can't restore a guest saved by an older qemu 2012-03-02 8:47 ` Jan Kiszka @ 2012-03-02 8:58 ` Zhang, Yang Z 2012-03-02 9:21 ` [PATCH] qemu-kvm: Fix migration from older version due to i8254 changes Jan Kiszka 0 siblings, 1 reply; 6+ messages in thread From: Zhang, Yang Z @ 2012-03-02 8:58 UTC (permalink / raw) To: Jan Kiszka, Ren, Yongjie; +Cc: Avi Kivity, KVM list After restoring i8254, the f->buf_index points to a wrong place. It should be caused by loading i8254. best regards yang > -----Original Message----- > From: kvm-owner@vger.kernel.org [mailto:kvm-owner@vger.kernel.org] On > Behalf Of Jan Kiszka > Sent: Friday, March 02, 2012 4:48 PM > To: Ren, Yongjie > Cc: Avi Kivity; KVM list > Subject: Re: can't restore a guest saved by an older qemu > > On 2012-03-02 07:33, Ren, Yongjie wrote: > > Hi Avi, > > I can't restore a guest saved by an older qemu. I wonder if this issue is > introduced by some latest commits on the file 'hw/i8254.c'. > > The new commit: b5ed4b6f (on Mar 1) I tried to restore a guest using this > qemu. > > The old commit: 9d636ae7 (on Feb 11) I saved a guest using this qemu. > > > > I got some error when restoring a guest saved by an old qemu now. > > [root@vt-nhm9 jay]# qemu-system-x86_64 -smp 4 -m 1024 -hda rhel6u1.qcow > -incoming "exec:dd if=save.img" > > Could not open option rom 'vapic.bin': No such file or directory > > qemu-system-x86_64: pci_add_option_rom: failed to find romfile > "pxe-rtl8139.rom" > > VNC server running on `::1:5900' > > Unknown ramblock "0000:00:03.0/rtl8139.rom", cannot accept migration > > qemu: warning: error while loading state for instance 0x0 of device 'ram' > > load of migration failed > > Confirmed. I get a different error, but something is broken here as well. > Bisecting... > > Thanks, > Jan > > -- > Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center > Embedded Linux > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a > message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] qemu-kvm: Fix migration from older version due to i8254 changes 2012-03-02 8:58 ` Zhang, Yang Z @ 2012-03-02 9:21 ` Jan Kiszka 2012-03-02 9:32 ` Ren, Yongjie 2012-03-07 10:48 ` Avi Kivity 0 siblings, 2 replies; 6+ messages in thread From: Jan Kiszka @ 2012-03-02 9:21 UTC (permalink / raw) To: Avi Kivity, Marcelo Tosatti; +Cc: Zhang, Yang Z, Ren, Yongjie, KVM list Old qemu-kvm already contained an equivalent field to i8254's irq_disabled. We therefore have to remove upstream's version restriction here to allow migration from older versions. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- hw/i8254.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/i8254.c b/hw/i8254.c index e5cda2f..33d94e1 100644 --- a/hw/i8254.c +++ b/hw/i8254.c @@ -469,7 +469,7 @@ VMStateDescription vmstate_pit = { .minimum_version_id_old = 1, .load_state_old = pit_load_old, .fields = (VMStateField []) { - VMSTATE_UINT32_V(channels[0].irq_disabled, PITState, 3), + VMSTATE_UINT32(channels[0].irq_disabled, PITState), /* qemu-kvm's v2 had 'flags' here */ VMSTATE_STRUCT_ARRAY(channels, PITState, 3, 2, vmstate_pit_channel, PITChannelState), VMSTATE_TIMER(channels[0].irq_timer, PITState), VMSTATE_END_OF_LIST() -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] qemu-kvm: Fix migration from older version due to i8254 changes 2012-03-02 9:21 ` [PATCH] qemu-kvm: Fix migration from older version due to i8254 changes Jan Kiszka @ 2012-03-02 9:32 ` Ren, Yongjie 2012-03-07 10:48 ` Avi Kivity 1 sibling, 0 replies; 6+ messages in thread From: Ren, Yongjie @ 2012-03-02 9:32 UTC (permalink / raw) To: Jan Kiszka, Avi Kivity, Marcelo Tosatti; +Cc: Zhang, Yang Z, KVM list This patch works fine. Tested by: Yongjie Ren <yongjie.ren@intel.com> Best Regards, Yongjie Ren (Jay) > -----Original Message----- > From: Jan Kiszka [mailto:jan.kiszka@siemens.com] > Sent: Friday, March 02, 2012 5:21 PM > To: Avi Kivity; Marcelo Tosatti > Cc: Zhang, Yang Z; Ren, Yongjie; KVM list > Subject: [PATCH] qemu-kvm: Fix migration from older version due to i8254 > changes > > Old qemu-kvm already contained an equivalent field to i8254's > irq_disabled. We therefore have to remove upstream's version restriction > here to allow migration from older versions. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > hw/i8254.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/i8254.c b/hw/i8254.c > index e5cda2f..33d94e1 100644 > --- a/hw/i8254.c > +++ b/hw/i8254.c > @@ -469,7 +469,7 @@ VMStateDescription vmstate_pit = { > .minimum_version_id_old = 1, > .load_state_old = pit_load_old, > .fields = (VMStateField []) { > - VMSTATE_UINT32_V(channels[0].irq_disabled, PITState, 3), > + VMSTATE_UINT32(channels[0].irq_disabled, PITState), /* > qemu-kvm's v2 had 'flags' here */ > VMSTATE_STRUCT_ARRAY(channels, PITState, 3, 2, > vmstate_pit_channel, PITChannelState), > VMSTATE_TIMER(channels[0].irq_timer, PITState), > VMSTATE_END_OF_LIST() > -- > 1.7.3.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] qemu-kvm: Fix migration from older version due to i8254 changes 2012-03-02 9:21 ` [PATCH] qemu-kvm: Fix migration from older version due to i8254 changes Jan Kiszka 2012-03-02 9:32 ` Ren, Yongjie @ 2012-03-07 10:48 ` Avi Kivity 1 sibling, 0 replies; 6+ messages in thread From: Avi Kivity @ 2012-03-07 10:48 UTC (permalink / raw) To: Jan Kiszka; +Cc: Marcelo Tosatti, Zhang, Yang Z, Ren, Yongjie, KVM list On 03/02/2012 11:21 AM, Jan Kiszka wrote: > Old qemu-kvm already contained an equivalent field to i8254's > irq_disabled. We therefore have to remove upstream's version restriction > here to allow migration from older versions. > Applied, thanks. -- error compiling committee.c: too many arguments to function ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-07 10:48 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-03-02 6:33 can't restore a guest saved by an older qemu Ren, Yongjie 2012-03-02 8:47 ` Jan Kiszka 2012-03-02 8:58 ` Zhang, Yang Z 2012-03-02 9:21 ` [PATCH] qemu-kvm: Fix migration from older version due to i8254 changes Jan Kiszka 2012-03-02 9:32 ` Ren, Yongjie 2012-03-07 10:48 ` Avi Kivity
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox