From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>,
mtosatti@redhat.com, kvm@vger.kernel.org, cotte@de.ibm.com,
Paul Mackerras <paulus@samba.org>,
borntraeger@de.ibm.com, Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH 4/4 v3] KVM: Introduce kvm_memory_slot::arch and move lpage_info into it
Date: Wed, 07 Mar 2012 17:03:54 +0200 [thread overview]
Message-ID: <4F5778DA.60805@redhat.com> (raw)
In-Reply-To: <4F577754.9090009@suse.de>
On 03/07/2012 04:57 PM, Alexander Graf wrote:
> On 03/07/2012 03:04 PM, Avi Kivity wrote:
>> On 03/07/2012 03:27 PM, Alexander Graf wrote:
>>>> At the time I made this patch, it seemed that only kvm-x86 supported
>>>> huge pages, on ppc the array should be empty:
>>>
>>> Hrm. I suppose this refers to transparent huge pages?
>> Just huge pages. Whether they are static or dynamic is immaterial in
>> this context.
>
> Well, book3s_hv and e500 support hugetlbfs. I've never had to touch
> that patches code though - so I guess I'm still not really
> understanding what it's there for O_o.
>
The kvm hugepage code uses large sptes to map large pages, when
available (either via hugetlbfs or transparent hugepages). Since x86
supports swapping, and needs to write-protect pages for dirty logging
and for shadowing guest pagetables, it needs a reverse map from pages to
sptes. The data structure we're discussing is part of the reverse map
for large pages.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-03-07 15:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 3:48 [PATCH 0/4] KVM: Introduce kvm_memory_slot::arch Takuya Yoshikawa
2012-01-30 3:50 ` [PATCH 1/4] KVM: Introduce gfn_to_index() which returns the index for a given level Takuya Yoshikawa
2012-01-30 3:50 ` [PATCH 2/4] KVM: Split lpage_info creation out from __kvm_set_memory_region() Takuya Yoshikawa
2012-01-30 3:51 ` [PATCH 3/4 v2] KVM: Simplify ifndef conditional usage in __kvm_set_memory_region() Takuya Yoshikawa
2012-01-30 3:53 ` [PATCH 4/4 v2] KVM: Introduce kvm_memory_slot::arch and move lpage_info into it Takuya Yoshikawa
2012-01-30 4:58 ` Takuya Yoshikawa
2012-01-30 5:35 ` [PATCH 4/4 v3] " Takuya Yoshikawa
2012-01-31 1:17 ` Takuya Yoshikawa
2012-01-31 7:51 ` Christian Borntraeger
2012-01-31 12:42 ` Takuya Yoshikawa
2012-01-31 9:18 ` Avi Kivity
2012-01-31 9:32 ` Takuya Yoshikawa
2012-03-06 23:01 ` Alexander Graf
2012-03-07 4:46 ` Takuya Yoshikawa
2012-03-07 13:27 ` Alexander Graf
2012-03-07 14:04 ` Avi Kivity
2012-03-07 14:57 ` Alexander Graf
2012-03-07 15:03 ` Avi Kivity [this message]
2012-03-07 15:28 ` Alexander Graf
2012-03-07 14:15 ` Takuya Yoshikawa
2012-03-07 21:58 ` Paul Mackerras
2012-02-06 10:10 ` [PATCH 0/4] KVM: Introduce kvm_memory_slot::arch Takuya Yoshikawa
2012-02-06 10:10 ` Avi Kivity
2012-02-07 17:42 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5778DA.60805@redhat.com \
--to=avi@redhat.com \
--cc=aarcange@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=paulus@samba.org \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).