From mboxrd@z Thu Jan  1 00:00:00 1970
From: Amos Kong <akong@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()
Date: Wed, 14 Mar 2012 15:51:01 +0800
Message-ID: <4F604DE5.1050101@redhat.com>
References: <20120306224330.24264.9494.stgit@dhcp-8-167.nay.redhat.com> <20120306224745.24264.19990.stgit@dhcp-8-167.nay.redhat.com> <4F60455C.7090406@redhat.com> <4F60485D.9050209@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Orit Wasserman <owasserm@redhat.com>, aliguori@us.ibm.com,
	kvm@vger.kernel.org, quintela@redhat.com, jasowang@redhat.com,
	qemu-devel@nongnu.org, laine@redhat.com
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:1387 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755265Ab2CNHvM (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 14 Mar 2012 03:51:12 -0400
In-Reply-To: <4F60485D.9050209@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 14/03/12 15:27, Paolo Bonzini wrote:
>

Hi Paolo,

> Il 14/03/2012 08:14, Orit Wasserman ha scritto:
>> if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))<  0)
>> {	
>>      closesocket(*fd);
>>      return -socket_error();
>> }
>> return 0;
>>
>> and than you will not need ret
>
> But closesocket could clobber socket_error(), no?

Yes, it will effect socket_error()

How about this fix ?

     ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr));
     if (ret < 0) {
         ret = -socket_error();
         closesocket(*fd);
     }
     return ret;
}

-- 
			Amos.