From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 5/7] RTC:Add RTC update-ended interrupt
 support
Date: Wed, 21 Mar 2012 08:49:29 +0100
Message-ID: <4F698809.1050202@redhat.com>
References: <A9667DDFB95DB7438FA9D7D576C3D87E09E751@SHSMSX101.ccr.corp.intel.com> <alpine.DEB.2.00.1203201752230.15151@kaball-desktop> <alpine.DEB.2.00.1203201832460.15151@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
	"aliguori@us.ibm.com" <aliguori@us.ibm.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:43887 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755124Ab2CUHtl (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 21 Mar 2012 03:49:41 -0400
In-Reply-To: <alpine.DEB.2.00.1203201832460.15151@kaball-desktop>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 20/03/2012 19:35, Stefano Stabellini ha scritto:
> This is the function that is used to figure out whether we need the
> timers or not, the condition seems to be:
> 
> (Not (REG_C_UF | REG_C_AF)) And (Not (REG_B_SET))
> 
> Shouldn't actually check for UIE being enabled?

No, you need to set UF in case the code observes it without actually
enabling interrupt delivery on the ISA bus.

Paolo