From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm-intel: Auto-load on CPUs with VMX. Date: Wed, 21 Mar 2012 15:41:38 +0200 Message-ID: <4F69DA92.6030107@redhat.com> References: <20120321063350.GA3468@leaf> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Josh Triplett Return-path: In-Reply-To: <20120321063350.GA3468@leaf> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 03/21/2012 08:33 AM, Josh Triplett wrote: > Enable x86 feature-based autoloading for the kvm-intel module on CPUs > with X86_FEATURE_VMX. > > Signed-off-by: Josh Triplett > --- > > I've tested this and it works correctly. I can also supply the obvious > equivalent patch for kvm-amd on AMD CPUs with SVM, but I don't have any > such CPUs to test that on. > On the one hand this makes sense and is consistent with how other modules are loaded. On the other hand this will waste memory for non-virt users running on distro kernels (but distro kernels can override this new behaviour anyway). I'm inclined to apply, but will wait for more comments. -- error compiling committee.c: too many arguments to function