From: Avi Kivity <avi@redhat.com>
To: kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] KVM: x86 emulator: MMX support
Date: Wed, 21 Mar 2012 23:32:58 +0200 [thread overview]
Message-ID: <4F6A490A.10802@redhat.com> (raw)
In-Reply-To: <1332355222-30508-2-git-send-email-avi@redhat.com>
On 03/21/2012 08:40 PM, Avi Kivity wrote:
>
> +static int flush_pending_x87_faults(struct x86_emulate_ctxt *ctxt)
> +{
> + bool fault = false;
> +
> + ctxt->ops->get_fpu(ctxt);
> + asm volatile("1: fwait \n\t"
> + "2: \n\t"
> + ".pushsection .fixup,\"ax\" \n\t"
> + "3: \n\t"
> + "movb $1, %[fault] \n\t"
> + "jmp 2b \n\t"
> + ".popsection \n\t"
> + _ASM_EXTABLE(1b, 3b)
> + : [fault]"=rm"(fault));
>
"=" tells gcc that the asm section unconditionally writes 'fault', so it
skips the initialization. Use "+" instead.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2012-03-21 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 18:40 [PATCH 0/2] Emulate MMX MOVQ Avi Kivity
2012-03-21 18:40 ` [PATCH 1/2] KVM: x86 emulator: MMX support Avi Kivity
2012-03-21 21:32 ` Avi Kivity [this message]
2012-03-21 18:40 ` [PATCH 2/2] KVM: x86 emulator: implement MMX MOVQ (opcodes 0f 6f, 0f 7f) Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2012-03-22 10:56 [PATCH 0/2] Emulate MMX MOVQ Avi Kivity
2012-03-22 10:56 ` [PATCH 1/2] KVM: x86 emulator: MMX support Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6A490A.10802@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox