From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"aliguori@us.ibm.com" <aliguori@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH v4 5/7] RTC:Add RTC update-ended interrupt support
Date: Thu, 22 Mar 2012 11:32:27 +0100 [thread overview]
Message-ID: <4F6AFFBB.5000006@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203221028420.15151@kaball-desktop>
Il 22/03/2012 11:29, Stefano Stabellini ha scritto:
>> The purpose of using two timer is trying to keep the UF, AF and UIP
>> synchronous. User can poll UIP to check UF and AF bit. If we use
>> timer for UF/AF bit track and check UIP by another way, since the
>> timer will be fired with delay, then the problem is encountered:
>> the UIP is cleared, but due to the delay of timer, the UF/AF bit is
>> not set. So we need to check them on a same level. Although we can
>> update UF/AF when reading it, the logic is too complicated,
>> especially for AF bit.
FWIW, the solution I used when I removed the second timer from the
current code (not yet posted, I do hope your patches can be fixed!) was
to set UIP when reading A, and clear it in the timer. You have
something like that, but keep the two timers.
Paolo
prev parent reply other threads:[~2012-03-22 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 6:14 [PATCH v4 5/7] RTC:Add RTC update-ended interrupt support Zhang, Yang Z
2012-03-20 18:04 ` [Qemu-devel] " Stefano Stabellini
2012-03-20 18:35 ` Stefano Stabellini
2012-03-21 7:49 ` Paolo Bonzini
2012-03-21 16:54 ` Stefano Stabellini
2012-03-21 21:16 ` Paolo Bonzini
2012-03-22 10:29 ` [Qemu-devel] " Stefano Stabellini
2012-03-22 0:04 ` Zhang, Yang Z
2012-03-22 10:29 ` Stefano Stabellini
2012-03-22 10:32 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6AFFBB.5000006@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox