From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: console class in kvm Date: Mon, 26 Mar 2012 12:18:54 +0200 Message-ID: <4F70428E.4070707@redhat.com> References: <20120326094824.GA14504@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Amit Shah , yan@daynix.com, qemu-devel@nongnu.org, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20120326094824.GA14504@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 03/26/2012 11:48 AM, Michael S. Tsirkin wrote: > kvm used to carry this commit: Used to? Which commit reverts this? > commit 4667e6ec0df770867095d8093562d93c94d96ca2 > Author: Avi Kivity > Date: Thu Feb 12 11:43:17 2009 +0200 > > Change virtio-console to PCI_CLASS_OTHERS > > As a PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP > (possibly Windows disables acceleration since it fails to find a driver). > > Signed-off-by: Avi Kivity > > This seems to have been dropped. Is the issue gone? > Could relevant parties speak up please? > Do we want to merge this commit into qemu.git? It's an impossible compatibility problem now. I have this sinking feeling that we need to create yet another driver property. -- error compiling committee.c: too many arguments to function