From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: console class in kvm Date: Mon, 26 Mar 2012 14:29:58 +0200 Message-ID: <4F706146.7040905@redhat.com> References: <20120326094824.GA14504@redhat.com> <4F70428E.4070707@redhat.com> <20120326111942.GA15207@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Amit Shah , yan@daynix.com, qemu-devel@nongnu.org, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57603 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753672Ab2CZMaI (ORCPT ); Mon, 26 Mar 2012 08:30:08 -0400 In-Reply-To: <20120326111942.GA15207@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/26/2012 01:19 PM, Michael S. Tsirkin wrote: > On Mon, Mar 26, 2012 at 12:18:54PM +0200, Avi Kivity wrote: > > On 03/26/2012 11:48 AM, Michael S. Tsirkin wrote: > > > kvm used to carry this commit: > > > > Used to? Which commit reverts this? > > A merge from qemu.git I would guess. > git log does not seem to show the culprit, I don't know > how to find it. It was e2478f504fff20ad (git log -SPCI_CLASS_OTHERS master -m -p). > > > commit 4667e6ec0df770867095d8093562d93c94d96ca2 > > > Author: Avi Kivity > > > Date: Thu Feb 12 11:43:17 2009 +0200 > > > > > > Change virtio-console to PCI_CLASS_OTHERS > > > > > > As a PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP > > > (possibly Windows disables acceleration since it fails to find a driver). > > > > > > Signed-off-by: Avi Kivity > > > > > > This seems to have been dropped. Is the issue gone? > > > Could relevant parties speak up please? > > > Do we want to merge this commit into qemu.git? > > > > It's an impossible compatibility problem now. I have this sinking > > feeling that we need to create yet another driver property. > > That's easy, we have a class property for this already. Yes, d6beee9938. -- error compiling committee.c: too many arguments to function