From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] kvm: set gsi_bits and max_gsi correctly Date: Wed, 28 Mar 2012 20:27:14 +0200 Message-ID: <4F735802.1020805@siemens.com> References: <201203281818.q2SII5ng021559@int-mx11.intmail.prod.int.phx2.redhat.com> <1332958820.3799.32.camel@bling.home> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Alex Williamson , Jason Baron , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" To: Avi Kivity , Marcelo Tosatti Return-path: Received: from goliath.siemens.de ([192.35.17.28]:15213 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932602Ab2C1S1W (ORCPT ); Wed, 28 Mar 2012 14:27:22 -0400 In-Reply-To: <1332958820.3799.32.camel@bling.home> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-03-28 20:20, Alex Williamson wrote: > On Wed, 2012-03-28 at 14:18 -0400, Jason Baron wrote: >> The current kvm_init_irq_routing() doesn't set up the used_gsi_bitmap >> correctly, and as a consequence pins max_gsi to 32 when it really >> should be 1024. I ran into this limitation while testing pci >> passthrough, where I consistently got an -ENOSPC return from >> kvm_get_irq_route_gsi() called from assigned_dev_update_msix_mmio(). >> >> Signed-off-by: Jason Baron >> --- >> kvm-all.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/kvm-all.c b/kvm-all.c >> index ab88c7c..b616c7d 100644 >> --- a/kvm-all.c >> +++ b/kvm-all.c >> @@ -873,7 +873,7 @@ static void kvm_init_irq_routing(KVMState *s) >> unsigned int gsi_bits, i; >> >> /* Round up so we can search ints using ffs */ >> - gsi_bits = (gsi_count + 31) / 32; >> + gsi_bits = ALIGN(gsi_count, 32); >> s->used_gsi_bitmap = g_malloc0(gsi_bits / 8); >> s->max_gsi = gsi_bits; >> > > Acked-by: Alex Williamson > Acked-by: Jan Kiszka Tagging this as "PATCH uq/master" may help Avi and Marcelo to identify and pick it up for that queue. Thanks, Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux