From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2] KVM: Introduce direct MSI message injection for in-kernel irqchips Date: Wed, 28 Mar 2012 22:21:35 +0200 Message-ID: <4F7372CF.6040804@web.de> References: <4F734EB3.20500@siemens.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig86F5CBEEBAC77A4E3B2267D5" Cc: Avi Kivity , Marcelo Tosatti , kvm , "Michael S. Tsirkin" To: Eric Northup Return-path: Received: from fmmailgate06.web.de ([217.72.192.247]:35790 "EHLO fmmailgate06.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758521Ab2C1UVm (ORCPT ); Wed, 28 Mar 2012 16:21:42 -0400 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate06.web.de (Postfix) with ESMTP id 9CC11104E74E for ; Wed, 28 Mar 2012 22:21:40 +0200 (CEST) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig86F5CBEEBAC77A4E3B2267D5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-03-28 21:58, Eric Northup wrote: > On Wed, Mar 28, 2012 at 10:47 AM, Jan Kiszka w= rote: > [...] >> +4.61 KVM_SET_MSI >> + >> +Capability: KVM_CAP_SET_MSI >> +Architectures: x86 >> +Type: vm ioctl >> +Parameters: struct kvm_msi (in) >> +Returns: 0 on success, -1 on error >=20 > Is this the actual behavior? It looked to me like the successful > return value ended up getting set by __apic_accept_irq(), which claims > to "Return 1 if successfully added and 0 if discarded". True. And I think we want this information, e.g. to implement IRQ decoalescing for periodic HPET timers that use MSIs. Will adjust the documentations. Thanks for reviewing, Jan --------------enig86F5CBEEBAC77A4E3B2267D5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9zctIACgkQitSsb3rl5xQ2pACgi1qKii1Rn3R9xYbRlXvVxqfC sIYAniXfkbSvsqsje2LWd/mFnh8muXvR =m+j9 -----END PGP SIGNATURE----- --------------enig86F5CBEEBAC77A4E3B2267D5--