From: Ren Mingxin <renmx@cn.fujitsu.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, jens.axboe@oracle.com
Cc: Rusty Russell <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] virtio_blk: add helper function to support mass of disks naming
Date: Thu, 29 Mar 2012 13:36:38 +0800 [thread overview]
Message-ID: <4F73F4E6.4060104@cn.fujitsu.com> (raw)
In-Reply-To: <20120328105819.GD6194@redhat.com>
On 03/28/2012 06:58 PM, Michael S. Tsirkin wrote:
> On Wed, Mar 28, 2012 at 02:54:43PM +0800, Ren Mingxin wrote:
>> Hi,
>>
>> The current virtblk's naming algorithm just supports 26^3
>> disks. If there are mass of virtblks(exceeding 26^3), there
>> will be disks with the same name.
>>
>> According to "sd_format_disk_name()", I add function
>> "virtblk_name_format()" for virtblk to support mass of
>> disks.
>>
>> Signed-off-by: Ren Mingxin<renmx@cn.fujitsu.com>
> Nod. This is basically what 3e1a7ff8a0a7b948f2684930166954f9e8e776fe
> did. Except, maybe we should move this function into block core
> instead of duplicating it? Where would be a good place to put it?
Yes, this was also what I thought.
How about placing the "sd_format_disk_name()"
as "disk_name_format()" into "block/genhd.c"
("include/linux/genhd.h")?
Thanks.
Ren
next prev parent reply other threads:[~2012-03-29 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4F72B5B3.6020602@cn.fujitsu.com>
2012-03-28 10:58 ` [PATCH] virtio_blk: add helper function to support mass of disks naming Michael S. Tsirkin
2012-03-29 4:40 ` Rusty Russell
2012-03-29 5:36 ` Ren Mingxin [this message]
2012-03-29 12:03 ` Jens Axboe
2012-03-29 12:46 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F73F4E6.4060104@cn.fujitsu.com \
--to=renmx@cn.fujitsu.com \
--cc=jens.axboe@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox