From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ren Mingxin <renmx@cn.fujitsu.com>
Subject: Re: [PATCH] virtio_blk: add helper function to support mass of disks
 naming
Date: Thu, 29 Mar 2012 13:36:38 +0800
Message-ID: <4F73F4E6.4060104@cn.fujitsu.com>
References: <4F72B5B3.6020602@cn.fujitsu.com> <20120328105819.GD6194@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	LKML <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	linux-scsi@vger.kernel.org
To: "Michael S. Tsirkin" <mst@redhat.com>, jens.axboe@oracle.com
Return-path: <linux-scsi-owner@vger.kernel.org>
In-Reply-To: <20120328105819.GD6194@redhat.com>
Sender: linux-scsi-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

  On 03/28/2012 06:58 PM, Michael S. Tsirkin wrote:
> On Wed, Mar 28, 2012 at 02:54:43PM +0800, Ren Mingxin wrote:
>>   Hi,
>>
>> The current virtblk's naming algorithm just supports 26^3
>> disks. If there are mass of virtblks(exceeding 26^3), there
>> will be disks with the same name.
>>
>> According to "sd_format_disk_name()", I add function
>> "virtblk_name_format()" for virtblk to support mass of
>> disks.
>>
>> Signed-off-by: Ren Mingxin<renmx@cn.fujitsu.com>
> Nod. This is basically what 3e1a7ff8a0a7b948f2684930166954f9e8e776fe
> did. Except, maybe we should move this function into block core
> instead of duplicating it? Where would be a good place to put it?

Yes, this was also what I thought.

How about placing the "sd_format_disk_name()"
as "disk_name_format()" into "block/genhd.c"
("include/linux/genhd.h")?

Thanks.
Ren