public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Avi Kivity <avi@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Juan Quintela <quintela@redhat.com>
Subject: Re: live migration between qemu-kvm 1.0 and 0.15
Date: Thu, 29 Mar 2012 17:53:50 +0200	[thread overview]
Message-ID: <4F74858E.9070806@siemens.com> (raw)
In-Reply-To: <4F747E78.3070501@codemonkey.ws>

On 2012-03-29 17:23, Anthony Liguori wrote:
> On 03/27/2012 12:42 PM, Jan Kiszka wrote:
>> On 2012-03-27 18:49, Anthony Liguori wrote:
>>> On 03/27/2012 11:46 AM, Avi Kivity wrote:
>>>> On 03/27/2012 06:39 PM, Anthony Liguori wrote:
>>>>>
>>>>> So, since we're approaching 1.1, we should really discuss release
>>>>> criteria for 1.1 with respect to live migration.  I'd prefer to avoid
>>>>> surprises in this release.
>>>>
>>>> Agree strongly.
>>>>
>>>>>
>>>>> My expectation is that migration works from:
>>>>>
>>>>> qemu-1.0 -M 1.0     =>      qemu-1.1 -M 1.1
>>>>
>>>> Why do you expect that?  Maybe you meant -M 1.0 at the end?
>>>
>>> Sorry, I did mean -M 1.0.
>>>
>>>>
>>>>> qemu-1.1 -M 1.0<=    qemu-1.1 -M 1.0
>>>>>
>>>>> I would expect that migration works from:
>>>>>
>>>>> qemu-0.15 -M 0.15   =>     qemu-1.1 -M 0.15
>>>>>
>>>>
>>>> Ack.
>>>>
>>>>> I'm okay if this fails gracefully:
>>>>>
>>>>> qemu-1.1 -M 0.15<=   qemu-0.15 -M 0.15
>>>>
>>>> RHEL has more stringent requirements (going back to its heavily patched
>>>> 0.12).  I think we should have the infrastructure that allow one to add
>>>> the hacks to make this work, even if we don't actually do the compat
>>>> work for the release (I think it's fine for qemu to support just one
>>>> version going back; and unreasonable to require it to go as far back as
>>>> RHEL).
>>>
>>> This is reasonable to me.
>>
>> Here is a draft to get things written in the old format. Totally
>> untested and likely borken (written in a hurry). I'll split up if it
>> works fine.
> 
> I don't really like this as a matter of principle.
> 
> Knowingly migrating when the result may be a broken guest is a bug, it's not a 
> feature.
> 
> It's one thing if we're changing formats for other reasons, but if we're 
> changing the format to send what's effectively broken migration state, then 
> that's an evil thing to do.
> 
> Subsections are the compromise.  We send a subsection when we think migration 
> can work and fail gracefully when it can't.  Presumably there's a reason we're 
> not using subsections here.

In this case (instance ID), it's actually not about a bug fix but a
consolidation of the vmstate format. So I think it's an exception,
though I don't like the code changes it requires as well.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2012-03-29 15:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27  8:55 live migration between qemu-kvm 1.0 and 0.15 Vasilis Liaskovitis
2012-03-27  9:55 ` Jan Kiszka
2012-03-27 15:59   ` Avi Kivity
2012-03-27 16:22     ` Jan Kiszka
2012-03-27 16:39       ` [Qemu-devel] " Anthony Liguori
2012-03-27 16:46         ` Avi Kivity
2012-03-27 16:49           ` Anthony Liguori
2012-03-27 17:42             ` Jan Kiszka
2012-03-29 15:23               ` Anthony Liguori
2012-03-29 15:53                 ` Jan Kiszka [this message]
2012-03-29 11:56         ` [Qemu-devel] " Jan Kiszka
2012-03-29 15:17           ` Avi Kivity
2012-03-29 15:21             ` Anthony Liguori
2012-03-29 15:25               ` Avi Kivity
2012-04-02 14:17         ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F74858E.9070806@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=vasilis.liaskovitis@profitbricks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox