From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raghavendra K T Subject: Re: [Qemu-devel] [PATCH V8 1/1] Guest stop notificationorry for rduplicate mail ndreas Date: Sat, 07 Apr 2012 05:57:21 +0530 Message-ID: <4F7F89E9.4000204@linux.vnet.ibm.com> References: <20120406072057.28181.31911.sendpatchset@codeblue> <4F7EB056.4080104@suse.de> <4F7EBC1F.5030300@linux.vnet.ibm.com> <4F7EE91A.9020204@linux.vnet.ibm.com> <4F7F5B75.5020501@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Anthony Liguori , KVM , Jan Kiszka , Marcelo Tosatti , Qemu-devel , Srivatsa Vaddagiri , "Michael J. Wolf" , Avi Kivity , Eric B Munson To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Return-path: Received: from e28smtp05.in.ibm.com ([122.248.162.5]:45679 "EHLO e28smtp05.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754149Ab2DGA2P (ORCPT ); Fri, 6 Apr 2012 20:28:15 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 7 Apr 2012 05:58:12 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q370SAjh4657348 for ; Sat, 7 Apr 2012 05:58:10 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q375wcXx020422 for ; Sat, 7 Apr 2012 15:58:39 +1000 In-Reply-To: <4F7F5B75.5020501@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 04/07/2012 02:39 AM, Andreas F=E4rber wrote: > Am 06.04.2012 15:01, schrieb Raghavendra K T: >> On 04/06/2012 03:19 PM, Raghavendra K T wrote: >>> On 04/06/2012 02:29 PM, Andreas F=E4rber wrote: >>>> Am 06.04.2012 09:21, schrieb Raghavendra K T: >>>>> From: Eric B Munson >>>>> >>>>> Often when a guest is stopped from the qemu console, it will repo= rt >>>>> spurious >>>>> soft lockup warnings on resume. There are kernel patches being >>>>> discussed that >>>>> will give the host the ability to tell the guest that it is being >>>>> stopped and >>>>> should ignore the soft lockup warning that generates. This patch = uses >>>>> the qemu >>>>> Notifier system to tell the guest it is about to be stopped. >>>>> >>>>> Signed-off-by: Eric B Munson >>>>> Signed-off-by: Raghavendra K T >>>>> >>>>> Cc: Eric B Munson >>>>> Cc: Avi Kivity >>>>> Cc: Marcelo Tosatti >>>>> Cc: Anthony Liguori >>>>> Cc: Jan Kiszka >>>>> Cc: "Andreas F=C3=A4rber" >>>>> --- >>>>> Changes from V7: >>>>> capabilty changed to KVM_CAP_KVMCLOCK_CTRL >>>>> KVM_GUEST_PAUSED is pervcpu again >>>>> CPUState renamed to CPUArchState >>>> >>>> Thanks, change looks right to me. >> >> I think I should have added Acked-by and resent full patch. So here = is >> it. sorry for duplicate mail. > > No, it was not intended as such since I can't ack the ioctl. Resends = are > best done with git-send-email, i.e. a v9 with change log (whether as > reply or not, opinions are divided) to make sure the right version ge= ts > applied in the end. Ok. Thanks Andreas. sending V9 shortly > [...] >> + if (ret) { >> + if (ret !=3D -EINVAL) { >> + fprintf(stderr, >> + " %s: %s\n", __FUNCTION__, > > Is the whitespace before %s intentional? Wasn't there in v8. > > The GCC manual recommends __func__, like I suggested, saying it's C99= =2E > http://gcc.gnu.org/onlinedocs/gcc-4.7.0/gcc/Function-Names.html#Funct= ion-Names > __FUNCTION__ usage is currently 432 vs. __func__ 579, so not wrong. > will correct them. > If you want to leave it that way you can add my > > Reviewed-by: Andreas F=E4rber > > Andreas > >> + strerror(-ret)); >> + } >> + return; >> + } >> + } >> } >> } >> >