From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2 07/16] KVM: MMU: introduce for_each_pte_list_spte Date: Mon, 16 Apr 2012 11:36:25 +0800 Message-ID: <4F8B93B9.2030801@linux.vnet.ibm.com> References: <4F87FA69.5060106@linux.vnet.ibm.com> <4F87FC19.8080404@linux.vnet.ibm.com> <20120414114422.e3fe6e2abbfdcce61e6f69c8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , LKML , KVM To: Takuya Yoshikawa Return-path: Received: from e23smtp07.au.ibm.com ([202.81.31.140]:47655 "EHLO e23smtp07.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721Ab2DPDmF (ORCPT ); Sun, 15 Apr 2012 23:42:05 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Apr 2012 03:29:48 +1000 In-Reply-To: <20120414114422.e3fe6e2abbfdcce61e6f69c8@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/14/2012 10:44 AM, Takuya Yoshikawa wrote: > On Fri, 13 Apr 2012 18:12:41 +0800b > Xiao Guangrong wrote: > >> It is used to walk all the sptes of the specified pte_list, after >> this, the code of pte_list_walk can be removed >> >> And it can restart the walking automatically if the spte is zapped > > Well, I want to ask two questions: > > - why do you prefer pte_list_* naming to rmap_*? > (not a big issue but just curious) pte_list is a common infrastructure for both parent-list and rmap. > - Are you sure the whole indirection by this patch will > not introduce any regression? > (not restricted to get_dirty) > I tested it with kernbench, no regression is found. It is not a problem since the iter and spte should be in the cache.