From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCHv1 dont apply] RFC: kvm eoi PV using shared memory Date: Tue, 17 Apr 2012 12:22:57 +0300 Message-ID: <4F8D3671.9090004@redhat.com> References: <20120410132756.GA14101@redhat.com> <20120415161857.GA8710@redhat.com> <20120416100807.GO11918@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41735 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755900Ab2DQJW7 (ORCPT ); Tue, 17 Apr 2012 05:22:59 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3H9Mxlt007020 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Apr 2012 05:22:59 -0400 In-Reply-To: <20120416100807.GO11918@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/16/2012 01:08 PM, Gleb Natapov wrote: > > } > > > > + > > + if (kvm_para_has_feature(KVM_FEATURE_EOI)) { > > + kvm_guest_native_apic_write = apic->write; > > + apic->write = kvm_guest_apic_write; > > + wrmsrl(MSR_KVM_EOI_EN, __pa(&__get_cpu_var(apic_eoi))); > > + } > Can happen on more then one cpu. After it happens on two kvm_guest_apic_write() > will call to itself. It's also hacky. Try static_cpu_has() in the apic code (and add an eoi method). -- error compiling committee.c: too many arguments to function