public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v3 1/3] Introduce a workqueue to deliver PIT timer interrupts.
Date: Tue, 17 Apr 2012 13:42:31 +0300	[thread overview]
Message-ID: <4F8D4917.5000703@redhat.com> (raw)
In-Reply-To: <20120417103106.GG11918@redhat.com>

On 04/17/2012 01:31 PM, Gleb Natapov wrote:
> On Tue, Apr 17, 2012 at 01:29:04PM +0300, Avi Kivity wrote:
> > On 04/17/2012 01:26 PM, Gleb Natapov wrote:
> > > > It isn't, since you need to send an IPI.
> > > > 
> > > That is exactly what I forget whether you can send IPI from there :)
> > > Anyway this is another reason.
> > >
> > 
> > Actually I was wrong.  You can't smp_call_function_single() from irq
> > context (deadlocks if two vcpus do that), but we send a reschedule
> > interrupt.  So it should work.
> > 
> Ah, good point. So if we'll use irqsave versions of spinlocks we can
> drop kthread?

Do we want 254 IPIs to be issued from irq context?  Could be slow.

We can make the unicast case run from irq context and defer the
multicast to a thread.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2012-04-17 10:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-16 21:11 [PATCH v3 0/3]: Fixes to IRQ routing Chris Lalancette
2010-06-16 21:11 ` [PATCH v3 1/3] Introduce a workqueue to deliver PIT timer interrupts Chris Lalancette
2012-04-16 16:33   ` Jan Kiszka
2012-04-16 17:07     ` Avi Kivity
2012-04-17  9:31     ` Gleb Natapov
2012-04-17 10:23       ` Avi Kivity
2012-04-17 10:26         ` Gleb Natapov
2012-04-17 10:29           ` Avi Kivity
2012-04-17 10:31             ` Gleb Natapov
2012-04-17 10:42               ` Avi Kivity [this message]
2012-04-17 10:43                 ` Avi Kivity
2012-04-17 11:05                 ` Gleb Natapov
2012-04-17 12:00                   ` Avi Kivity
2012-04-17 12:03                     ` Gleb Natapov
2012-04-17 12:06                       ` Avi Kivity
2012-04-17 16:15                         ` Jan Kiszka
2012-04-17 16:17                           ` Avi Kivity
2012-04-18  8:04                             ` Gleb Natapov
2012-04-18  8:25                               ` Avi Kivity
2012-04-18  8:27                                 ` Gleb Natapov
2010-06-16 21:11 ` [PATCH v3 2/3] Allow any LAPIC to accept PIC interrupts Chris Lalancette
2010-06-16 21:11 ` [PATCH v3 3/3] In DM_LOWEST, only deliver interrupts to vcpus with enabled LAPIC's Chris Lalancette
2010-06-18 17:44 ` [PATCH v3 0/3]: Fixes to IRQ routing Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8D4917.5000703@redhat.com \
    --to=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox