From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org, mtosatti@redhat.com, mst@redhat.com
Subject: Re: [PATCH] Introduce bitmask for apic attention reasons.
Date: Thu, 19 Apr 2012 13:45:26 +0300 [thread overview]
Message-ID: <4F8FECC6.10801@redhat.com> (raw)
In-Reply-To: <4F8FEA89.4020909@redhat.com>
On 04/19/2012 01:35 PM, Avi Kivity wrote:
> On 04/19/2012 01:26 PM, Gleb Natapov wrote:
> > >
> > > Unrelated: this pattern is probably common. Would be nice to have a
> > > __deposit_bit() function.
> > >
> > What semantics should it have? Set bit A in bitmap B if value C is
> > non-zero?
> >
>
> void __deposit_bit(bool bit, unsigned index, unsigned long *word)
> {
> if (bit)
> __set_bit(...)
> else
> __clear_bit(...)
> }
>
> I think some processors have an instruction for it (not an s390 reference).
>
Looks like x86 will get one too: PDEP.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-04-19 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 9:33 [PATCH] Introduce bitmask for apic attention reasons Gleb Natapov
2012-04-19 9:53 ` Avi Kivity
2012-04-19 10:26 ` Gleb Natapov
2012-04-19 10:35 ` Avi Kivity
2012-04-19 10:45 ` Avi Kivity [this message]
2012-04-19 10:05 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8FECC6.10801@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox