From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v3 2/9] KVM: MMU: abstract spte write-protect Date: Sat, 21 Apr 2012 12:34:30 +0800 Message-ID: <4F9238D6.3030706@gmail.com> References: <4F911B74.4040305@linux.vnet.ibm.com> <4F911BAB.6000206@linux.vnet.ibm.com> <20120420213319.GA13817@amt.cnet> <20120421101049.421a744ba5898b6173159cb4@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Xiao Guangrong , Avi Kivity , LKML , KVM To: Takuya Yoshikawa Return-path: In-Reply-To: <20120421101049.421a744ba5898b6173159cb4@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 04/21/2012 09:10 AM, Takuya Yoshikawa wrote: > On Fri, 20 Apr 2012 18:33:19 -0300 > Marcelo Tosatti wrote: > >> It is preferable to remove all large sptes including read-only ones, the >> current behaviour, then to verify that no read->write transition can >> occur in fault paths (fault paths which are increasing in number). >> > > I think we should use separate function than spte_write_protect() for > the large case. I will introduce a function to handle large sptes when i implement the idea of making writable spte to be read-only. But, keep it in this patchset first.