From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH RFC] KVM: MMU: Don't use RCU for lockless shadow walking
Date: Tue, 24 Apr 2012 12:23:35 +0300 [thread overview]
Message-ID: <4F967117.4010509@redhat.com> (raw)
In-Reply-To: <4F96703F.4000607@redhat.com>
On 04/24/2012 12:19 PM, Avi Kivity wrote:
> > We need a mb here to avoid that setting vcpu->mode is reordered to the head
> > of reading/writing spte? (it is safe on x86, but we need a comment at least?)
>
> I don't think so. Documentation/memory-barriers says:
>
> Any atomic operation that modifies some state in memory and returns
> information
>
But we have some non-atomic writes to sptes. Will fix.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-04-24 9:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 16:16 [PATCH RFC] KVM: MMU: Don't use RCU for lockless shadow walking Avi Kivity
2012-04-24 1:17 ` Marcelo Tosatti
2012-04-24 9:24 ` Avi Kivity
2012-05-14 12:41 ` Avi Kivity
2012-04-24 6:37 ` Xiao Guangrong
2012-04-24 9:19 ` Avi Kivity
2012-04-24 9:23 ` Avi Kivity [this message]
2012-04-24 9:54 ` Xiao Guangrong
2012-04-24 10:02 ` Avi Kivity
2012-04-24 10:05 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F967117.4010509@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).