From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp
Subject: Re: [PATCH 0/4] KVM: x86 emulator: Split decoder into separate functions
Date: Tue, 24 Apr 2012 17:11:54 +0300 [thread overview]
Message-ID: <4F96B4AA.8030204@redhat.com> (raw)
In-Reply-To: <20120424003159.4fd245ec18b0b3eeddbea553@gmail.com>
On 04/23/2012 06:31 PM, Takuya Yoshikawa wrote:
> Takuya Yoshikawa (4):
> KVM: x86 emulator: Introduce ctxt->op_prefix for 0x66 prefix
> KVM: x86 emulator: Make prefix decoding a separate function
> KVM: x86 emulator: Make opcode decoding a separate function
>
I don't see the benefit for the first three patches. They add more
state, and don't encourage any reuse. The current code is complicated,
but just splitting it doesn't really fix that.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-04-24 14:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 15:31 [PATCH 0/4] KVM: x86 emulator: Split decoder into separate functions Takuya Yoshikawa
2012-04-23 15:33 ` [PATCH 1/4] KVM: x86 emulator: Introduce ctxt->op_prefix for 0x66 prefix Takuya Yoshikawa
2012-04-23 15:34 ` [PATCH 2/4] KVM: x86 emulator: Make prefix decoding a separate function Takuya Yoshikawa
2012-04-23 15:35 ` [PATCH 3/4] KVM: x86 emulator: Make opcode " Takuya Yoshikawa
2012-04-23 15:37 ` [PATCH 4/4] KVM: x86 emulator: Avoid pushing back ModRM byte in decode_opcode() Takuya Yoshikawa
2012-04-24 14:10 ` Avi Kivity
2012-04-24 14:27 ` Takuya Yoshikawa
2012-04-24 14:11 ` Avi Kivity [this message]
2012-04-24 14:41 ` [PATCH 0/4] KVM: x86 emulator: Split decoder into separate functions Takuya Yoshikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F96B4AA.8030204@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox