From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/4] KVM: x86 emulator: Split decoder into separate functions Date: Tue, 24 Apr 2012 17:11:54 +0300 Message-ID: <4F96B4AA.8030204@redhat.com> References: <20120424003159.4fd245ec18b0b3eeddbea553@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:8243 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754474Ab2DXOMA (ORCPT ); Tue, 24 Apr 2012 10:12:00 -0400 In-Reply-To: <20120424003159.4fd245ec18b0b3eeddbea553@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/23/2012 06:31 PM, Takuya Yoshikawa wrote: > Takuya Yoshikawa (4): > KVM: x86 emulator: Introduce ctxt->op_prefix for 0x66 prefix > KVM: x86 emulator: Make prefix decoding a separate function > KVM: x86 emulator: Make opcode decoding a separate function > I don't see the benefit for the first three patches. They add more state, and don't encourage any reuse. The current code is complicated, but just splitting it doesn't really fix that. -- error compiling committee.c: too many arguments to function