From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tossati <mtosatti@redhat.com>,
Carsten Otte <cotte@de.ibm.com>, Alexander Graf <agraf@suse.de>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heinz Graalfs <graalfs@linux.vnet.ibm.com>,
KVM <kvm@vger.kernel.org>, Konstantin Weitz <WEITZKON@de.ibm.com>
Subject: Re: [PATCH 1/3v2] kvm-s390: Implement the directed yield (diag 9c) hypervisor call for KVM
Date: Tue, 24 Apr 2012 17:47:34 +0200 [thread overview]
Message-ID: <4F96CB16.8060700@de.ibm.com> (raw)
In-Reply-To: <4F96A55E.1050703@redhat.com>
> I think the code will me more readable, and less obvious that is was
> copied from kvm_vcpu_on_spin(), if you put all the processing outside
> the loop, except for matching the vpu itself.
>
> So the code reads
>
> find a vcpu
> obtain the task
> do the yield
>
> instead of looking like you're doing the processing for every vcpu. The
> loop is just a slow lookup which might some day be replaced by a table
> lookup.
Ok. We might also have a kvm_vcpu_on_spin_directed in common code,
Would you prefer that?
Christian
next prev parent reply other threads:[~2012-04-24 15:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 7:24 [PATCH 0/3] Fixes and feature for kvm-s390 Christian Borntraeger
2012-04-24 7:24 ` [PATCH 1/3] kvm-s390: Implement the directed yield (diag 9c) hypervisor call for KVM Christian Borntraeger
2012-04-24 12:04 ` Avi Kivity
2012-04-24 12:44 ` Christian Borntraeger
2012-04-24 12:55 ` [PATCH 1/3v2] " Christian Borntraeger
2012-04-24 13:06 ` Avi Kivity
2012-04-24 15:47 ` Christian Borntraeger [this message]
2012-04-24 16:15 ` Avi Kivity
2012-04-24 16:21 ` Christian Borntraeger
2012-04-24 16:22 ` Avi Kivity
2012-04-25 13:30 ` [PATCH 0/2] rework kvm_vcpu_on_spin Christian Borntraeger
2012-04-25 13:30 ` [PATCH 1/2] kvm-s390: Implement the directed yield (diag 9c) hypervisor call for KVM Christian Borntraeger
2012-04-26 12:06 ` Alexander Graf
2012-04-26 12:19 ` Christian Borntraeger
2012-04-26 12:26 ` Alexander Graf
2012-04-25 13:30 ` [PATCH 2/2] kvm-s390: use kvm_vcpu_on_spin for diag 0x44 Christian Borntraeger
2012-04-29 11:10 ` [PATCH 0/2] rework kvm_vcpu_on_spin Avi Kivity
2012-06-06 12:55 ` trace points and ABI Christian Borntraeger
2012-06-06 13:12 ` Avi Kivity
2012-04-24 7:24 ` [PATCH 2/3] kvm-s390: Handle sckpf instruction Christian Borntraeger
2012-04-24 7:24 ` [PATCH 3/3] kvm-s390: implement KVM_CAP_MAX_VCPUS Christian Borntraeger
2012-04-24 12:06 ` Avi Kivity
2012-04-24 12:47 ` Christian Borntraeger
2012-04-24 13:01 ` Avi Kivity
2012-05-01 0:51 ` Marcelo Tosatti
2012-05-01 1:00 ` Marcelo Tosatti
2012-05-02 8:50 ` [PATCH 0/1] Updated Patch for NR/MAX VCPU on s390 Christian Borntraeger
2012-05-02 8:50 ` [PATCH 1/1] kvm-s390x: implement KVM_CAP_NR/MAX_VCPUS Christian Borntraeger
2012-05-02 21:36 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F96CB16.8060700@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=WEITZKON@de.ibm.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=graalfs@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox