From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1 v2] KVM: Reduce mmu_lock contention during dirty logging by cond_resched() Date: Sun, 29 Apr 2012 15:59:18 +0300 Message-ID: <4F9D3B26.7090602@redhat.com> References: <20120428190544.7dc2bfd281054c1fcac5a14e@gmail.com> <20120428190754.5c27325da5663e5d8c9b9be1@gmail.com> <4F9D25A2.7020303@redhat.com> <20120429211759.0265df80d7193048344ff35b@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:21704 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896Ab2D2M7Y (ORCPT ); Sun, 29 Apr 2012 08:59:24 -0400 In-Reply-To: <20120429211759.0265df80d7193048344ff35b@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/29/2012 03:17 PM, Takuya Yoshikawa wrote: > > Oh, but this might trick a later rmap_write_protect() into thinking that > > no write protection and tlb flush is needed. So we should touch > > kvm->tlbs_dirty. > > The problem was making others think that > "already protected, no need to flush." > > As we discussed before, we need to add some tricks to de-couple mmu_lock and > TLB flush. Ok, let's discuss them (we can apply the patch independently). Do you have something in mind? -- error compiling committee.c: too many arguments to function