public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org, mtosatti@redhat.com, mst@redhat.com
Subject: Re: [PATCH] kvm_para_available() should check hypervisor bit before accessing hypervisor cpuid leaf.
Date: Tue, 01 May 2012 15:59:33 +0300	[thread overview]
Message-ID: <4F9FDE35.4060100@redhat.com> (raw)
In-Reply-To: <20120501125546.GI22191@redhat.com>

On 05/01/2012 03:55 PM, Gleb Natapov wrote:
> On Tue, May 01, 2012 at 03:50:44PM +0300, Avi Kivity wrote:
> > On 04/30/2012 02:45 PM, Gleb Natapov wrote:
> > > This couid range does not exist on real HW and Intel spec says that
> > > "Information returned for highest basic information leaf" will be
> > > returned. Not very well defined. 
> > >
> > 
> > Correct in principle.  But IIRC some old qemus supported the kvm cpuid
> > range without setting the hypervisor bit.
> > 
> How old?

commit e19967a0e00c7af4efd2f2db12a7d5d7f0b387f7
Author: Avi Kivity <avi@qumranet.com>
Date:   Tue Apr 22 11:44:19 2008 +0300

    Set "hypervisor present" cpuid bit
   
    This tells Microsoft guests that they are running under a hypervisor.
   
    Signed-off-by: Avi Kivity <avi@qumranet.com

$ git describe --contains e19967a0e00c
kvm-80rc2~489

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2012-05-01 12:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-30 11:45 [PATCH] kvm_para_available() should check hypervisor bit before accessing hypervisor cpuid leaf Gleb Natapov
2012-04-30 16:37 ` Davidlohr Bueso
2012-05-01  6:52   ` Gleb Natapov
2012-05-01 12:50 ` Avi Kivity
2012-05-01 12:55   ` Gleb Natapov
2012-05-01 12:59     ` Avi Kivity [this message]
2012-05-02 12:09       ` Gleb Natapov
2012-05-06 12:55         ` Avi Kivity
2012-05-06 13:00 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F9FDE35.4060100@redhat.com \
    --to=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox