Re: [PATCH] KVM: X86: Remove stale values from ctxt->memop before emulation

Joerg Roedel
2012-05-07T10:43:09Z

On Mon, May 07, 2012 at 01:18:01PM +0300, Avi Kivity wrote:
> On 05/07/2012 01:12 PM, Joerg Roedel wrote:
> >
> > The instruction emulation for bsrw is broken in KVM because
> > the code always uses bsr with 32 or 64 bit operand size for
> > emulation. Fix that by using emulate_2op_SrcV_nobyte() macro
> > to use guest operand size for emulation.
> >
>
> It looks fine. Do you know what triggered this regression? (for
> figuring out if it's 3.4 material)

Looks like it is 3.4 (and -stable) material. I tested a few older
kernels and the test passes on 3.0 but fails on 3.2 an later kernels
(I have not tested 3.1).

Joerg

--
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632