From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: X86: Add mmx movq emulation Date: Sun, 06 May 2012 13:08:05 +0300 Message-ID: <4FA64D85.1000609@redhat.com> References: <1336132029-13523-1-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Joerg Roedel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:30058 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753094Ab2EFKIJ (ORCPT ); Sun, 6 May 2012 06:08:09 -0400 In-Reply-To: <1336132029-13523-1-git-send-email-joerg.roedel@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/04/2012 02:47 PM, Joerg Roedel wrote: > Add support to the MMX versions of the movq instructions to > the instruction emulator. Also handle possible exceptions > they may cause. This is already in (cbe2c9d30, e59717550e). Are you looking at master instead of next? Since you've just thought of the issues involved, I'd appreciate a review of the commits above, both wrt correctness and maintainability. In fact I already see one difference - my patches do reg &= 7, while your patches generate #UD for %mm8-%mm15. -- error compiling committee.c: too many arguments to function