From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] async PF event can fail to wakeup vcpu from halt Date: Sun, 06 May 2012 14:57:12 +0300 Message-ID: <4FA66718.5060603@redhat.com> References: <20120503083639.GT22191@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, marcelo@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22704 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753376Ab2EFL5Q (ORCPT ); Sun, 6 May 2012 07:57:16 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q46BvFJH005348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 6 May 2012 07:57:15 -0400 In-Reply-To: <20120503083639.GT22191@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/03/2012 11:36 AM, Gleb Natapov wrote: > If vcpu executes hlt instruction while async PF is waiting to be delivered > vcpu can block and deliver async PF only after another even wakes it > up. This happens because kvm_check_async_pf_completion() will remove > completion event from vcpu->async_pf.done before entering kvm_vcpu_block() > and this will make kvm_arch_vcpu_runnable() return false. The solution > is to make vcpu runnable when processing completion. > > Thanks, applied to master for 3.4. -- error compiling committee.c: too many arguments to function