public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: Gleb Natapov <gleb@redhat.com>, kvm@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [PATCH unit-tests] Add async page fault test
Date: Wed, 09 May 2012 16:20:23 +0300	[thread overview]
Message-ID: <4FAA6F17.1070308@redhat.com> (raw)
In-Reply-To: <20120509221807.8d04edc62ad1986785109cf1@gmail.com>

On 05/09/2012 04:18 PM, Takuya Yoshikawa wrote:
> On Wed, 9 May 2012 11:59:17 +0300
> Gleb Natapov <gleb@redhat.com> wrote:
>
> > Hmm, yes if it is file backed it may work. Setting up qemu to use file
> > backed memory is one more complication while running the test though.
> > I haven't checked by I am not sure that MADV_DONTNEED will drop page
> > immediately though. It probably puts it on some list to be freed later.
> > Hmm actually looking at the comments it seems like this is what happens:
> > 
> > /*
> >  * Application no longer needs these pages.  If the pages are dirty,
> >  * it's OK to just throw them away.  The app will be more careful about
> >  * data it wants to keep.  Be sure to free swap resources too.  The
> >  * zap_page_range call sets things up for shrink_active_list to actually
> >  * free
> >  * these pages later if no one else has touched them in the meantime,
> >  * although we could add these pages to a global reuse list for
> >  * shrink_active_list to pick up before reclaiming other pages.
> >  */
>
> zap_page_range() actually frees these pages, no?
>
> Virtio balloon seems to rely on this.
>

The pages are removed from the user address space.  But if they're not
anonymous, the pages still live in the page cache.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2012-05-09 13:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08 11:24 [PATCH unit-tests] Add async page fault test Gleb Natapov
2012-05-09  8:29 ` Avi Kivity
2012-05-09  8:41   ` Gleb Natapov
2012-05-09  8:52     ` Avi Kivity
2012-05-09  8:59       ` Gleb Natapov
2012-05-09 13:18         ` Takuya Yoshikawa
2012-05-09 13:20           ` Avi Kivity [this message]
2012-05-09 13:31             ` Takuya Yoshikawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAA6F17.1070308@redhat.com \
    --to=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=takuya.yoshikawa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox