From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on
 server CPUs
Date: Thu, 10 May 2012 20:55:36 +0300
Message-ID: <4FAC0118.9040908@redhat.com>
References: <1335505422.4578.3.camel@pasglop> <1335505900.4578.9.camel@pasglop> <4FABFFAD.3040602@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	kvm@vger.kernel.org, kvm-ppc <kvm-ppc@vger.kernel.org>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <4FABFFAD.3040602@suse.de>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 05/10/2012 08:49 PM, Alexander Graf wrote:
>> +#if defined(TARGET_PPC64)
>> +    if (def->sps)
>> +        memcpy(&env->sps, def->sps, sizeof(*def->sps));
>
>
> I never know if *def->... would dereference def or the complete
> construct. 

'man operator'

> How about sizeof(env->sps)?

How about

  env->sps = *def->sps;

?

-- 
error compiling committee.c: too many arguments to function