From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 1/3 - qemu-kvm stable-1.0] Fix conditional build of various x86 specific bits Date: Wed, 23 May 2012 23:51:40 -0300 Message-ID: <4FBDA23C.5000608@web.de> References: <1337825690.3038.50.camel@pasglop> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig194FCD927E9545F02A544EEC" Cc: Avi Kivity , kvm@vger.kernel.org, Marcelo Tosatti To: Benjamin Herrenschmidt Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:39394 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993Ab2EXCvr (ORCPT ); Wed, 23 May 2012 22:51:47 -0400 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate02.web.de (Postfix) with ESMTP id 568EB1C4D2D0A for ; Thu, 24 May 2012 04:51:45 +0200 (CEST) In-Reply-To: <1337825690.3038.50.camel@pasglop> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig194FCD927E9545F02A544EEC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-05-23 23:14, Benjamin Herrenschmidt wrote: > This adds/modifies ifdefs etc. and moves code to make sure that > x86-specific code doesn't get compiled on non-x86 platforms. > These changes all relate to code that is in the qemu-kvm tree and > not in the qemu tree. >=20 > The change from KVM_CAP_IRQCHIP to KVM_IRQCHIP_PIC_MASTER is because > the KVM_CAP_IRQCHIP symbol is defined on all platforms (though the > capability only exists on x86), whereas KVM_IRQCHIP_PIC_MASTER is > only defined on x86. (If a better symbol exists it could be used > instead.) >=20 > Signed-off-by: Benjamin Herrenschmidt > --- >=20 > An equivalent of this is already in qemu-kvm master as commit id > 20ad1def644494f5055d129961d46b050c0a6158 What is the interest of patching qemu-kvm for non-x86? It is not supposed to be used for this. And the affected bits are history in 1.1 (or 1.2 latest). Are there distros proving QEMU based on qemu-kvm for non-x86 hosts? Jan --------------enig194FCD927E9545F02A544EEC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk+9ojwACgkQitSsb3rl5xTWvwCaAhf/Gyk+PJR/w1QJecJatQ9t GLwAnj+1Z8l2NL4FbhGTLF5tKB2RiIrQ =/zET -----END PGP SIGNATURE----- --------------enig194FCD927E9545F02A544EEC--