From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] Provide fast path for "rep ins" emulation if possible. Date: Thu, 24 May 2012 13:36:51 +0300 Message-ID: <4FBE0F43.4060408@redhat.com> References: <1337782095-32287-1-git-send-email-gleb@redhat.com> <1337782095-32287-3-git-send-email-gleb@redhat.com> <4FBCF6EB.8040604@redhat.com> <4FBCF8FB.6050308@redhat.com> <20120524103457.GK2604@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm@vger.kernel.org, mtosatti@redhat.com To: "Roedel, Joerg" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1530 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932524Ab2EXKgz (ORCPT ); Thu, 24 May 2012 06:36:55 -0400 In-Reply-To: <20120524103457.GK2604@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/24/2012 01:34 PM, Roedel, Joerg wrote: > On Wed, May 23, 2012 at 05:49:31PM +0300, Avi Kivity wrote: >> On 05/23/2012 05:40 PM, Avi Kivity wrote: >> > On 05/23/2012 05:08 PM, Gleb Natapov wrote: >> > If decode assists are not available, we still need to emulate, see 15.33.5. >> > >> >> Joerg, the 2010 version of the manual says that the effective segment >> (10:12) is only available with decode assists. The 2012 version says >> it's unconditional. What's correct? > > It is still conditional and only available with decode-assists. I will > talk to the APM authors to clarify this in the documentation. Thanks. As it happens it doesn't matter for INS emulation, only OUTS, unless other bits in that word also depend on decode assists. -- error compiling committee.c: too many arguments to function