From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2 13/15] net: Remove obsolete vlan info Date: Thu, 24 May 2012 09:09:54 -0300 Message-ID: <4FBE2512.50704@siemens.com> References: <1337786045-2277-1-git-send-email-zwu.kernel@gmail.com> <1337786045-2277-14-git-send-email-zwu.kernel@gmail.com> <4FBD0525.4040107@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "stefanha@linux.vnet.ibm.com" , "kvm@vger.kernel.org" , "linuxram@us.ibm.com" , "qemu-devel@nongnu.org" , "wuzhy@linux.vnet.ibm.com" , "pbonzini@redhat.com" To: Zhi Yong Wu Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 2012-05-23 23:42, Zhi Yong Wu wrote: > On Wed, May 23, 2012 at 11:41 PM, Jan Kiszka wrote: >> On 2012-05-23 12:14, zwu.kernel@gmail.com wrote: >>> From: Zhi Yong Wu >>> >>> Signed-off-by: Zhi Yong Wu >>> --- >>> net.c | 1 - >>> 1 files changed, 0 insertions(+), 1 deletions(-) >>> >>> diff --git a/net.c b/net.c >>> index 61dc28d..8c8e703 100644 >>> --- a/net.c >>> +++ b/net.c >>> @@ -1079,7 +1079,6 @@ void do_info_network(Monitor *mon) >>> NetClientState *nc, *peer; >>> net_client_type type; >>> >>> - monitor_printf(mon, "Devices not on any VLAN:\n"); >>> QTAILQ_FOREACH(nc, &net_clients, next) { >>> peer = nc->peer; >>> type = nc->info->type; >> >> This looks suspicious - or the patch description is improvable. This is >> really just about removing that headline? And what about the indention >> of the lines printed afterward? > As you have known, vlan concept is replaced with hub. So i think that > it is more reasonable to remove this in monitor. That is true. But the output formatting is still improvable. >> >> It also leads me to the question how hub-based networks will be >> visualized on "info network", specifically when there are multiple hubs. >> Can you provide some more complex example of an info network output? > > (qemu) info network > virtio-net-pci.0: type=nic,model=virtio-net-pci,macaddr=52:54:00:12:34:56 > \ hub0port0: type=(null), > virtio-net-pci.1: type=nic,model=virtio-net-pci,macaddr=52:54:00:12:34:57 > \ hub1port0: type=(null), > hub 1 > port 1 peer user.1 > port 0 peer virtio-net-pci.1 > hub 0 > port 1 peer user.0 > port 0 peer virtio-net-pci.0 What about a layout like this: hub.0 \ virtio-net-pci.0: ... \ virtio-net-pci.1: ... \ user.0: ... hub.1 \ e1000.0: ... e1000.1: ... \ user.1: ... ie. printing the hubs first, listing all the peers of their ports underneath them. Also, things like "type=(null)" should be avoided. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux