From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [RFC PATCH] vfio: add fixup for broken PCI devices Date: Mon, 28 May 2012 14:48:10 +0200 Message-ID: <4FC3740A.4060801@web.de> References: <4FBF3627.3030504@ozlabs.ru> <20120528124410.GC21778@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig554EC45226DD9AE59A435456" Cc: Alexey Kardashevskiy , Alex Williamson , kvm@vger.kernel.org, qemu-devel@nongnu.org, Alex Graf , David Gibson To: "Michael S. Tsirkin" Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:39374 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105Ab2E1MsY (ORCPT ); Mon, 28 May 2012 08:48:24 -0400 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate01.web.de (Postfix) with ESMTP id 6BD3A1AEFAD53 for ; Mon, 28 May 2012 14:48:23 +0200 (CEST) In-Reply-To: <20120528124410.GC21778@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig554EC45226DD9AE59A435456 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-05-28 14:44, Michael S. Tsirkin wrote: > On Fri, May 25, 2012 at 05:35:03PM +1000, Alexey Kardashevskiy wrote: >> Some adapters (like NEC PCI USB controller) do not flush their config >> on a sioftware reset and remember DMA config, etc. >> >> If we use such an adapter with QEMU, then crash QEMU (stop it with >> ctrl-A ctrl-X), and try to use it in QEMU again, it may start working >> immediately with previous config when pci_enable_device() is called >> on that PCI function. >> >> To eliminate such effect, some quirk should be called. The proposed >> pci_fixup_final does its job well for mentioned NEC PCI USB but not >> sure if it is 100% correct. >> >> Signed-off-by: Alexey Kardashevskiy >=20 > Won't current kvm device assignment be affected by this? Would be surprising if not. > If yes need to address that not just vfio. A reason to solve this at PCI level? Jan --------------enig554EC45226DD9AE59A435456 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/DdAoACgkQitSsb3rl5xTiOACg068i6ejwn96EHIZSTSXNP2hl nsgAmwc1ZHnsJ8uhux6zbEM94DP4++Mh =brQb -----END PGP SIGNATURE----- --------------enig554EC45226DD9AE59A435456--