kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: [PATCH v6 1/9] KVM: MMU: return bool in __rmap_write_protect
Date: Tue, 29 May 2012 14:47:07 +0800	[thread overview]
Message-ID: <4FC470EB.3000101@linux.vnet.ibm.com> (raw)
In-Reply-To: <4FC470C7.5040700@linux.vnet.ibm.com>

The reture value of __rmap_write_protect is either 1 or 0, use
true/false instead of these

Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
---
 arch/x86/kvm/mmu.c |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 72102e0..ddbf89f 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -1051,11 +1051,12 @@ static void drop_spte(struct kvm *kvm, u64 *sptep)
 		rmap_remove(kvm, sptep);
 }

-static int __rmap_write_protect(struct kvm *kvm, unsigned long *rmapp, int level)
+static bool
+__rmap_write_protect(struct kvm *kvm, unsigned long *rmapp, int level)
 {
 	u64 *sptep;
 	struct rmap_iterator iter;
-	int write_protected = 0;
+	bool write_protected = false;

 	for (sptep = rmap_get_first(*rmapp, &iter); sptep;) {
 		BUG_ON(!(*sptep & PT_PRESENT_MASK));
@@ -1076,7 +1077,7 @@ static int __rmap_write_protect(struct kvm *kvm, unsigned long *rmapp, int level
 			sptep = rmap_get_first(*rmapp, &iter);
 		}

-		write_protected = 1;
+		write_protected = true;
 	}

 	return write_protected;
@@ -1107,12 +1108,12 @@ void kvm_mmu_write_protect_pt_masked(struct kvm *kvm,
 	}
 }

-static int rmap_write_protect(struct kvm *kvm, u64 gfn)
+static bool rmap_write_protect(struct kvm *kvm, u64 gfn)
 {
 	struct kvm_memory_slot *slot;
 	unsigned long *rmapp;
 	int i;
-	int write_protected = 0;
+	bool write_protected = false;

 	slot = gfn_to_memslot(kvm, gfn);

@@ -1701,7 +1702,7 @@ static void mmu_sync_children(struct kvm_vcpu *vcpu,

 	kvm_mmu_pages_init(parent, &parents, &pages);
 	while (mmu_unsync_walk(parent, &pages)) {
-		int protected = 0;
+		bool protected = false;

 		for_each_sp(pages, sp, parents, i)
 			protected |= rmap_write_protect(vcpu->kvm, sp->gfn);
-- 
1.7.7.6


  reply	other threads:[~2012-05-29  6:47 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-29  6:46 [PATCH v6 0/9] KVM: MMU: fast page fault Xiao Guangrong
2012-05-29  6:47 ` Xiao Guangrong [this message]
2012-05-29  6:47 ` [PATCH v6 2/9] KVM: MMU: abstract spte write-protect Xiao Guangrong
2012-05-29  6:48 ` [PATCH v6 3/9] KVM: VMX: export PFEC.P bit on ept Xiao Guangrong
2012-05-29  6:48 ` [PATCH v6 4/9] KVM: MMU: fold tlb flush judgement into mmu_spte_update Xiao Guangrong
2012-05-29  6:49 ` [PATCH v6 5/9] KVM: MMU: introduce SPTE_MMU_WRITEABLE bit Xiao Guangrong
2012-06-11 23:32   ` Marcelo Tosatti
2012-06-12  2:23     ` Xiao Guangrong
2012-06-13  2:01       ` Marcelo Tosatti
2012-06-13  3:11         ` Xiao Guangrong
2012-06-13 21:39   ` Marcelo Tosatti
2012-06-14  1:13     ` Takuya Yoshikawa
2012-06-14  2:41       ` Xiao Guangrong
2012-06-14  2:36     ` Xiao Guangrong
2012-05-29  6:50 ` [PATCH v6 6/9] KVM: MMU: fast path of handling guest page fault Xiao Guangrong
2012-06-13 22:40   ` Marcelo Tosatti
2012-06-14  1:22     ` Takuya Yoshikawa
2012-06-18 19:21       ` Marcelo Tosatti
2012-06-19  2:07         ` Takuya Yoshikawa
2012-06-14  3:00     ` Xiao Guangrong
2012-06-18 19:32       ` Marcelo Tosatti
2012-06-19  2:04         ` Xiao Guangrong
2012-05-29  6:51 ` [PATCH v6 7/9] KVM: MMU: trace fast " Xiao Guangrong
2012-05-29  6:51 ` [PATCH v6 8/9] KVM: MMU: fix kvm_mmu_pagetable_walk tracepoint Xiao Guangrong
2012-05-29  6:52 ` [PATCH v6 9/9] KVM: MMU: document mmu-lock and fast page fault Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC470EB.3000101@linux.vnet.ibm.com \
    --to=xiaoguangrong@linux.vnet.ibm.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).