From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC][PATCH] pci-assign: Drop support for raw ioport access Date: Tue, 29 May 2012 17:00:32 +0300 Message-ID: <4FC4D680.3030801@redhat.com> References: <4FC377AD.8060201@web.de> <4FC38659.8090309@redhat.com> <4FC47F28.3040008@siemens.com> <4FC49647.2020805@redhat.com> <1338299279.4714.98.camel@ul30vt> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Marcelo Tosatti , kvm To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:35156 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102Ab2E2OAh (ORCPT ); Tue, 29 May 2012 10:00:37 -0400 In-Reply-To: <1338299279.4714.98.camel@ul30vt> Sender: kvm-owner@vger.kernel.org List-ID: On 05/29/2012 04:47 PM, Alex Williamson wrote: > On Tue, 2012-05-29 at 12:26 +0300, Avi Kivity wrote: >> On 05/29/2012 10:47 AM, Jan Kiszka wrote: >> > >> >> >> >> Under what conditions would the kernel not support ioport access via sysfs? >> >> >> > >> > No clue. The oldest kernel I checked (2.6.16) does not contain traces it >> > would refuse to provide access. >> >> I guess this was added first, and sysfs support was added later >> (9ed83e8eb18b0). Alex, any idea what kernels would fail this? > > It's more recent than that. 8633328b is where we added pci-sysfs ioport > access, so 2.6.35 would be the first kernel with it. I don't really > know how this ever worked except for a very limited range of io ports > addresses before the sysfs access went in, so I'm ok with removing it. > Thanks, > Okay. Both patches applied, thanks. -- error compiling committee.c: too many arguments to function