From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] pci-assign: Hide ioport regions on lacking sysfs support Date: Tue, 29 May 2012 20:13:49 +0300 Message-ID: <4FC503CD.6010804@redhat.com> References: <4FC501BA.5010105@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm , Alex Williamson To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10872 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754597Ab2E2RNy (ORCPT ); Tue, 29 May 2012 13:13:54 -0400 In-Reply-To: <4FC501BA.5010105@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/29/2012 08:04 PM, Jan Kiszka wrote: > As suggested by Alex: Instead of failing if the kernel does not allow us > to speak to an ioport region, warn the user but, hide the region and > continue. Should we not, in addition, abort if the region is actually used? A guest malfunction is likely if we don't. -- error compiling committee.c: too many arguments to function