From: Avi Kivity <avi@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] pci-assign: Hide ioport regions on lacking sysfs support
Date: Wed, 30 May 2012 11:21:06 +0300 [thread overview]
Message-ID: <4FC5D872.6080702@redhat.com> (raw)
In-Reply-To: <1338312532.4714.139.camel@ul30vt>
On 05/29/2012 08:28 PM, Alex Williamson wrote:
> On Tue, 2012-05-29 at 20:13 +0300, Avi Kivity wrote:
>> On 05/29/2012 08:04 PM, Jan Kiszka wrote:
>> > As suggested by Alex: Instead of failing if the kernel does not allow us
>> > to speak to an ioport region, warn the user but, hide the region and
>> > continue.
>>
>>
>> Should we not, in addition, abort if the region is actually used? A
>> guest malfunction is likely if we don't.
>
> The only way we could know that it's used is if it's the device ends up
> with no valid regions as a result of this. Otherwise it's dependent on
> both the device and the driver whether it can still function without the
> i/o port regions. Thanks,
If the I/O callback is called, we know it's used.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-05-30 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 17:04 [PATCH] pci-assign: Hide ioport regions on lacking sysfs support Jan Kiszka
2012-05-29 17:11 ` Alex Williamson
2012-05-29 17:13 ` Avi Kivity
2012-05-29 17:28 ` Alex Williamson
2012-05-30 8:21 ` Avi Kivity [this message]
2012-05-30 8:47 ` Jan Kiszka
2012-05-30 8:50 ` Avi Kivity
2012-05-30 9:01 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC5D872.6080702@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox