From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Fix PCI header check on device assignment Date: Wed, 06 Jun 2012 14:12:39 +0300 Message-ID: <4FCF3B27.7050600@redhat.com> References: <4FCDC54B.1020605@siemens.com> <1338916415.23475.223.camel@bling.home> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Marcelo Tosatti , kvm , vedun@ispras.ru To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61454 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751784Ab2FFLNA (ORCPT ); Wed, 6 Jun 2012 07:13:00 -0400 In-Reply-To: <1338916415.23475.223.camel@bling.home> Sender: kvm-owner@vger.kernel.org List-ID: On 06/05/2012 08:13 PM, Alex Williamson wrote: > On Tue, 2012-06-05 at 10:37 +0200, Jan Kiszka wrote: >> The masking was wrong (must have been 0x7f), and there is no need to >> re-read the value as pci_setup_device already does this for us. > > The intent was to mask off the multifunction bit from header_type, but > the implementation is clearly wrong. hdr_type does both. Thanks > >> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43339 >> Signed-off-by: Jan Kiszka > > Acked-by: Alex Williamson >>From your comment in the bugzilla entry I conclude that there is no need to get this into 3.5. is this correct? -- error compiling committee.c: too many arguments to function