From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] kvm: First step to push iothread lock out of inner run loop Date: Sun, 24 Jun 2012 16:40:15 +0200 Message-ID: <4FE726CF.5090906@web.de> References: <4FE4F56D.1020201@web.de> <4FE4F7F5.7030400@web.de> <20120623002259.GA13440@amt.cnet> <20120623090646.GA21908@amt.cnet> <4FE5AC75.1020504@web.de> <4FE71F71.7030908@web.de> <4FE7259F.4030100@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA4836B3C9AFCAB1525AAC760" Cc: Liu Ping Fan , kvm , qemu-devel , Marcelo Tosatti , Alexander Graf , liu ping fan , Anthony Liguori To: Avi Kivity Return-path: In-Reply-To: <4FE7259F.4030100@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA4836B3C9AFCAB1525AAC760 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-06-24 16:35, Avi Kivity wrote: > On 06/24/2012 05:08 PM, Jan Kiszka wrote: >> As a first step, I will post a series later that gets rid of >> kvm_flush_coalesced_mmio_buffer in the common vmexit path. >=20 > If you defer this, I can think of two places that need to flush: > - anything that accesses those memory areas (such as DMA to the > framebuffer, or updating the display) - anything that accesses related areas (in case of VGA: PIO accesses to the control ports). I'm providing memory_region_set_flush_coalesced that allows to flush on non-coalesced region accesses as well. Some PIO accesses unfortunately still need open-coded qemu_flush_coalesced_mmio_buffer as they do not use memory regions yet. > - anything that modifies the memory map and possibly changes flushed > addresses Good point, need to address this. Jan --------------enigA4836B3C9AFCAB1525AAC760 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/nJs8ACgkQitSsb3rl5xQ+sACfcd0FhNnpmmPFAQ4NowGArUkU quAAoJ2EGDxoLlPIRjsE0qsnSTmoYMhp =p0zg -----END PGP SIGNATURE----- --------------enigA4836B3C9AFCAB1525AAC760--