From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/5] memory: Flush coalesced MMIO on selected region access Date: Mon, 25 Jun 2012 11:36:40 +0300 Message-ID: <4FE82318.3070806@redhat.com> References: <714b875f084134ae31596687651e051d4aa3c585.1340607659.git.jan.kiszka@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , qemu-devel , kvm , Liu Ping Fan , Marcelo Tosatti To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:24544 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189Ab2FYIgu (ORCPT ); Mon, 25 Jun 2012 04:36:50 -0400 In-Reply-To: <714b875f084134ae31596687651e051d4aa3c585.1340607659.git.jan.kiszka@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/25/2012 10:00 AM, Jan Kiszka wrote: > Instead of flushing pending coalesced MMIO requests on every vmexit, > this provides a mechanism to selectively flush when memory regions > related to the coalesced one are accessed. This first of all includes > the coalesced region itself but can also applied to other regions, e.g. > @@ -521,6 +522,18 @@ void memory_region_add_coalescing(MemoryRegion *mr, > void memory_region_clear_coalescing(MemoryRegion *mr); > > /** > + * memory_region_set_flush_coalesced: Enforce memory coalescing flush before > + * accesses. > + * > + * Ensure that pending coalesced MMIO request are flushed before the memory > + * region is accessed. This property is automatically enabled for all regions > + * passed to memory_region_set_coalescing() and memory_region_add_coalescing(). > + * > + * @mr: the memory region to be updated. > + */ > +void memory_region_set_flush_coalesced(MemoryRegion *mr); > + > +/** Please provide a way to clear the flag (and autoclear on clear_coalesced). -- error compiling committee.c: too many arguments to function