From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH] kvm: Don't abort on kvm_irqchip_add_msi_route()
Date: Mon, 25 Jun 2012 22:28:58 +0200
Message-ID: <4FE8CA0A.7000005@web.de>
References: <20120625154024.3598.7168.stgit@bling.home>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig090C9127F5FD4360925E3758"
Cc: avi@redhat.com, kvm@vger.kernel.org, mtosatti@redhat.com,
	qemu-devel@nongnu.org
To: Alex Williamson <alex.williamson@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mout.web.de ([212.227.15.4]:60718 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753651Ab2FYU3H (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 25 Jun 2012 16:29:07 -0400
In-Reply-To: <20120625154024.3598.7168.stgit@bling.home>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig090C9127F5FD4360925E3758
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 2012-06-25 17:40, Alex Williamson wrote:
> Anyone using these functions has to be prepared that irqchip
> support may not be present.  It shouldn't be up to the core
> code to determine whether this is a fatal error.  Currently
> code written as:
>=20
> virq =3D kvm_irqchip_add_msi_route(...)
> if (virq < 0) {
>     <slow path>
> } else {
>     <fast path>
> }
>=20
> works on x86 with and without kvm irqchip enabled, works
> without kvm support compiled in, but aborts() on !x86 with
> kvm support.
>=20
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>=20
>  kvm-all.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/kvm-all.c b/kvm-all.c
> index 45d00cd..b2ed702 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1146,7 +1146,7 @@ int kvm_irqchip_send_msi(KVMState *s, MSIMessage =
msg)
> =20
>  int kvm_irqchip_add_msi_route(KVMState *s, MSIMessage msg)
>  {
> -    abort();
> +    return -ENOSYS;
>  }
> =20
>  static int kvm_irqchip_assign_irqfd(KVMState *s, int fd, int virq, boo=
l assign)
>=20

Acked-by: Jan Kiszka <jan.kiszka@siemens.com>


--------------enig090C9127F5FD4360925E3758
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/oygoACgkQitSsb3rl5xRthgCggiPI5h9MxPr68cvEb+Uf25ZQ
PkIAoNInuG7A3yTR4HJjufwJyFqKb2MY
=MXfa
-----END PGP SIGNATURE-----

--------------enig090C9127F5FD4360925E3758--