From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 3/6] kvm: Sanitize KVM_IRQFD flags Date: Thu, 28 Jun 2012 15:35:59 +0300 Message-ID: <4FEC4FAF.8030700@redhat.com> References: <20120627044758.23698.249.stgit@bling.home> <20120627050924.23698.65802.stgit@bling.home> <20120627092150.GD17507@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Alex Williamson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jan.kiszka@siemens.com To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20120627092150.GD17507@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 06/27/2012 12:21 PM, Michael S. Tsirkin wrote: > On Tue, Jun 26, 2012 at 11:09:32PM -0600, Alex Williamson wrote: >> We only know of one so far. >> >> Signed-off-by: Alex Williamson > > Ugh. So we have a bug: we should have sanitized the fields. > If there's buggy userspace that only set the low bit > it will break with this change. > Is it too late now? Do we need KVM_IRQFD2 which > sanitized fields properly? Avi? We try and see. Commit this, if somebody complain, revert after apologizing profusely. If no one notices, we can claim those bits. -- error compiling committee.c: too many arguments to function