From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [RFC PATCH 06/18] KVM: Add facility to run guests on slave CPUs
Date: Thu, 28 Jun 2012 20:02:26 +0300
Message-ID: <4FEC8E22.4000208@redhat.com>
References: <20120628060719.19298.43879.stgit@localhost.localdomain> <20120628060751.19298.39801.stgit@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org,
	yrl.pp-manager.tt@hitachi.com,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>
To: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20120628060751.19298.39801.stgit@localhost.localdomain>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 06/28/2012 09:07 AM, Tomoki Sekiyama wrote:
> Add path to migrate execution of vcpu_enter_guest to a slave CPU when
> vcpu->arch.slave_cpu is set.
> 
> After moving to the slave CPU, it goes back to the online CPU when the
> guest is exited by reasons that cannot be handled by the slave CPU only
> (e.g. handling async page faults).

What about, say, instruction emulation?  It may need to touch guest
memory, which cannot be done from interrupt disabled context.

> +
> +static int vcpu_post_run(struct kvm_vcpu *vcpu, struct task_struct *task,
> +			 int *can_complete_async_pf)
> +{
> +	int r = LOOP_ONLINE;
> +
> +	clear_bit(KVM_REQ_PENDING_TIMER, &vcpu->requests);
> +	if (kvm_cpu_has_pending_timer(vcpu))
> +		kvm_inject_pending_timer_irqs(vcpu);
> +
> +	if (dm_request_for_irq_injection(vcpu)) {
> +		r = -EINTR;
> +		vcpu->run->exit_reason = KVM_EXIT_INTR;
> +		++vcpu->stat.request_irq_exits;
> +	}
> +
> +	if (can_complete_async_pf) {
> +		*can_complete_async_pf = kvm_can_complete_async_pf(vcpu);
> +		if (r == LOOP_ONLINE)
> +			r = *can_complete_async_pf ? LOOP_APF : LOOP_SLAVE;
> +	} else
> +		kvm_check_async_pf_completion(vcpu);
> +
> +	if (signal_pending(task)) {
> +		r = -EINTR;
> +		vcpu->run->exit_reason = KVM_EXIT_INTR;
> +		++vcpu->stat.signal_exits;
> +	}

Isn't this racy?  The signal can come right after this.

-- 
error compiling committee.c: too many arguments to function