From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, agraf@suse.de, paulus@samba.org,
aarcange@redhat.com, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org,
takuya.yoshikawa@gmail.com
Subject: Re: [PATCH 6/6] KVM: MMU: Avoid handling same rmap_pde in kvm_handle_hva_range()
Date: Sun, 01 Jul 2012 10:41:05 +0300 [thread overview]
Message-ID: <4FEFFF11.4000309@redhat.com> (raw)
In-Reply-To: <20120629104629.b369cd40.yoshikawa.takuya@oss.ntt.co.jp>
On 06/29/2012 04:46 AM, Takuya Yoshikawa wrote:
> On Thu, 28 Jun 2012 20:53:47 +0300
> Avi Kivity <avi@redhat.com> wrote:
>
>> > Note: in the new code we could not use trace_kvm_age_page(), so we just
>> > dropped the point from kvm_handle_hva_range().
>> >
>>
>> Can't it be pushed to handler()?
>
> Yes, but it will be changed to print rmap, not hva and gfn.
> I will do in the next version.
We should try to avoid changing the tracepoint ABI. If we pass the
memslot to handler(), we should be able to reconstruct the gfn and hva.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-07-01 7:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 1:57 [PATCH 0/6] KVM: Optimize MMU notifier's THP page invalidation -v3 Takuya Yoshikawa
2012-06-28 1:58 ` [PATCH 1/6] KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() Takuya Yoshikawa
2012-06-28 1:59 ` [PATCH 2/6] KVM: Introduce hva_to_gfn_memslot() for kvm_handle_hva() Takuya Yoshikawa
2012-06-28 2:00 ` [PATCH 3/6] KVM: MMU: Make kvm_handle_hva() handle range of addresses Takuya Yoshikawa
2012-06-28 2:00 ` [PATCH 4/6] KVM: Introduce kvm_unmap_hva_range() for kvm_mmu_notifier_invalidate_range_start() Takuya Yoshikawa
2012-06-28 2:01 ` [PATCH 5/6] KVM: Separate rmap_pde from kvm_lpage_info->write_count Takuya Yoshikawa
2012-06-28 3:12 ` Xiao Guangrong
2012-06-28 3:45 ` Takuya Yoshikawa
2012-06-28 17:39 ` Avi Kivity
2012-06-29 1:44 ` Takuya Yoshikawa
2012-07-02 2:22 ` Xiao Guangrong
2012-06-28 2:02 ` [PATCH 6/6] KVM: MMU: Avoid handling same rmap_pde in kvm_handle_hva_range() Takuya Yoshikawa
2012-06-28 17:53 ` Avi Kivity
2012-06-29 1:46 ` Takuya Yoshikawa
2012-07-01 7:41 ` Avi Kivity [this message]
2012-07-01 13:18 ` Takuya Yoshikawa
2012-07-01 13:31 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2012-06-21 8:48 [PATCH 0/6] KVM: Optimize MMU notifier's THP page invalidation -v2 Takuya Yoshikawa
2012-06-21 8:52 ` [PATCH 6/6] KVM: MMU: Avoid handling same rmap_pde in kvm_handle_hva_range() Takuya Yoshikawa
2012-06-22 14:33 ` Takuya Yoshikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEFFF11.4000309@redhat.com \
--to=avi@redhat.com \
--cc=aarcange@redhat.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=paulus@samba.org \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).