From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access Date: Mon, 02 Jul 2012 12:07:00 +0300 Message-ID: <4FF164B4.50306@redhat.com> References: <35d20ce2ae928e21ff715c86f854860d164ff8c9.1340814444.git.jan.kiszka@siemens.com> <4FEC814C.9040808@redhat.com> <4FEDD9E7.9040702@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , qemu-devel , kvm , Liu Ping Fan , Marcelo Tosatti To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29039 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932410Ab2GBJHJ (ORCPT ); Mon, 2 Jul 2012 05:07:09 -0400 In-Reply-To: <4FEDD9E7.9040702@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/29/2012 07:37 PM, Jan Kiszka wrote: > Instead of flushing pending coalesced MMIO requests on every vmexit, > this provides a mechanism to selectively flush when memory regions > related to the coalesced one are accessed. This first of all includes > the coalesced region itself but can also applied to other regions, e.g. > of the same device, by calling memory_region_set_flush_coalesced. Looks fine. I have a hard time deciding whether this should go through the kvm tree or memory tree. Anthony, perhaps you can commit it directly to avoid the livelock? Reviewed-by: Avi Kivity -- error compiling committee.c: too many arguments to function